Repository navigation
Fix dateutil timezone ID detection on Windows - #2143
yash-yeole wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Thanks for the pull request, @yash-yeole! A maintainer will review it shortly. |
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
There was a problem hiding this comment.
🔵 Needs a closer look
The change affects Windows-specific dateutil filename and zoneinfo behavior that cannot be exercised in this environment, so human validation of the relevant path scenarios is still needed.
No open issues 🎉
2 resolved since last review
Review effort: Lite


Description
Fixes an issue where
tzids_from_tzinfo()fails to identify dateutil timezone IDs on Windows.In some environments, dateutil timezone objects expose a relative IANA timezone filename (for example,
Pacific/Fiji), whileDATEUTIL_ZONEINFO_PATHandDATEUTIL_UTC_PATHare unavailable. The existing implementation relies on the zoneinfo root path to identify these filenames, causing timezone identification to return an empty tuple.This change:
zoneinfo.available_timezones().Testing
python -m pytest -q src/icalendar/tests/test_timezone_identification.py— 1812 passed.python -m pytest -q src/icalendar/tests/test_issue_722_generate_vtimezone.py— 788 passed, 13 skipped.AI Usage
Claude Sonnet 5.5 was used to investigate dateutil behavior and assist with implementation and regression tests.
ChatGPT GPT-6 was used to review the implementation, investigate platform-specific behavior, and validate the changes.
Closes #2142