Repository navigation
Post-move cleanup: last collective link and PyPI Trusted Publishing - #2134
Open
SashankBhamidi wants to merge 1 commit into
Open
SashankBhamidi wants to merge 1 commit into
SashankBhamidi wants to merge 1 commit into
Conversation
SashankBhamidi
requested review from
niccokunzmann and
stevepiercy
as code owners
November 16, 2026 09:14
Contributor
|
Thanks for the pull request, @SashankBhamidi! A maintainer will review it shortly. |
stevepiercy
approved these changes
Nov 16, 2026
Member
|
I can't answer your questions. They're for @niccokunzmann. |
Member
|
Changes to the other release branches can be made when they need a release. Maybe they do not. There is no need to remove the token. You can also replace it. Then the old releases would still work. The next release is a 8.0.0a(1 or 0), so people can try things out and we can polish it. Can be made any time. There is more to do for a stable release. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
Two last bits from the move.
First, the last
collective/icalendarlink.test_version_directives.pylanded in #2082 just before #2090 was merged, so it slipped through. It now points at PyCalendar.Second, the fun one: releases now go to PyPI through Trusted Publishing instead of the
TWINE_*token stored in thePyPIenvironment. GitHub proves to PyPI that the upload really comes from our release workflow, so there's no long-lived token sitting around to leak, or to stop working when the person who created it leaves. ThePyPIenvironment and its required reviewers stay as they are, so every release still needs a person to approve it. I've also added a line to the maintenance docs saying where publishing is configured.Before merging
Please don't merge this until PyPI is set up, or the next release will fail at the upload step.
PyCalendar, repositoryicalendar, workflowtests.yml, environmentPyPI(ofc one of you could do it while you're alreday on the manage page).Two questions
Do the old release branches still get releases?
6.x,5.xand4.xstill upload with the token, and Plone 6.1 tracks6.x, so a security fix there would need to reach PyPI. If any of them still get releases, I'll backport this change to them before we revoke the token. If not, we can delete the secrets and revoke the token after the next release. Until then, the token stays.When is the next release, and what version? We should cut one soon, so the PyPI page picks up the PyCalendar links. #2090 changed the default
PRODID, which is marked as breaking, so does that make it 8.0.0, or do we treat it as a minor change?