Skip to content

Post-move cleanup: last collective link and PyPI Trusted Publishing - #2134

Open
SashankBhamidi wants to merge 1 commit into
mainfrom
post-move-cleanup
Open

SashankBhamidi wants to merge 1 commit into
mainfrom
post-move-cleanup

Conversation

@SashankBhamidi

Copy link
Copy Markdown
Member

Linked issue

Description

Two last bits from the move.

First, the last collective/icalendar link. test_version_directives.py landed in #2082 just before #2090 was merged, so it slipped through. It now points at PyCalendar.

Second, the fun one: releases now go to PyPI through Trusted Publishing instead of the TWINE_* token stored in the PyPI environment. GitHub proves to PyPI that the upload really comes from our release workflow, so there's no long-lived token sitting around to leak, or to stop working when the person who created it leaves. The PyPI environment and its required reviewers stay as they are, so every release still needs a person to approve it. I've also added a line to the maintenance docs saying where publishing is configured.

Before merging

Please don't merge this until PyPI is set up, or the next release will fail at the upload step.

  1. @niccokunzmann or @stevepiercy moves icalendar into the PyCalendar organization on PyPI. That gives me the owner access I need for the next step.
  2. I add the trusted publisher on icalendar's Publishing page: owner PyCalendar, repository icalendar, workflow tests.yml, environment PyPI (ofc one of you could do it while you're alreday on the manage page).

Two questions

Do the old release branches still get releases? 6.x, 5.x and 4.x still upload with the token, and Plone 6.1 tracks 6.x, so a security fix there would need to reach PyPI. If any of them still get releases, I'll backport this change to them before we revoke the token. If not, we can delete the secrets and revoke the token after the next release. Until then, the token stays.

When is the next release, and what version? We should cut one soon, so the PyPI page picks up the PyCalendar links. #2090 changed the default PRODID, which is marked as breaking, so does that make it 8.0.0, or do we treat it as a minor change?

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @SashankBhamidi! A maintainer will review it shortly.

@stevepiercy stevepiercy removed their assignment Nov 16, 2026
@stevepiercy

Copy link
Copy Markdown
Member

I can't answer your questions. They're for @niccokunzmann.

@niccokunzmann

Copy link
Copy Markdown
Member

Changes to the other release branches can be made when they need a release. Maybe they do not.

There is no need to remove the token. You can also replace it. Then the old releases would still work.

The next release is a 8.0.0a(1 or 0), so people can try things out and we can polish it. Can be made any time. There is more to do for a stable release.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants