Repository navigation
Conversation
Prajas02
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 15, 2026 12:42
Contributor
|
Thanks for the pull request, @Prajas02! A maintainer will review it shortly. |
Contributor
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
Contributor
|
One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates. Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it. If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures. |
Collaborator
|
Thank you for the contribution. Please follow our responsible AI usage and clarify how you used AI. The policy is linked below. PLease read it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2123
What this changes
REQUEST-STATUSwas written with escaped field separators (2.0\;Success), which is not valid RFC 5545 and is not readable by other clients. Parsing also split a field at an escaped\;.vRequestStatusalready stores its value in the escaped wire form (new()escapes each field and thedescription/dataaccessors unescape them), so the fix makes the reader and writer agree with that:vRequestStatus.to_ical()writes the value as is, without escaping the separators again.vRequestStatus.get_value_from_content_line()hands the raw, still escaped value to the type. This uses the hook the parser already offers for value types that must not be unescaped (asvUnknowndoes).2.0\;Success) are detected and unescaped once, so existing files are still read correctly.\n, so they cannot break the content line.Before / after
vRequestStatus.new("3.1", "Invalid property value", "DTSTART:96-Apr-01")3.1\;Invalid property value\;DTSTART:96-Apr-013.1;Invalid property value;DTSTART:96-Apr-012.0;Success\; with note;x\,ySuccess, datawith note;x,ySuccess; with note, datax,y2.0\;Success(2, 0),Success(2, 0),SuccessTests
14 of the new tests fail on main and pass with this change. The full test suite and ruff pass.
Checklist
news/