Skip to content

Add ical_value property to vTime - #2105

Open
wmortenson199 wants to merge 5 commits into
PyCalendar:mainfrom
Dahshan228:ical-value-vtime
Open

wmortenson199 wants to merge 5 commits into
PyCalendar:mainfrom
Dahshan228:ical-value-vtime

Conversation

@wmortenson199

@wmortenson199 wmortenson199 commented Nov 12, 2026 •

Copy link
Copy Markdown

Linked issue

Description

Adds an ical_value property to vTime that returns the stored time, following the pattern used for vDate (#1965). Includes two tests and a news entry.

AI disclosure: I used Claude Opus 5.5 to draft the property, its tests, and the news entry. I reviewed, placed, and tested the code myself. The commit message and news entry say the same.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @wmortenson199! A maintainer will review it shortly.

@github-actions

Copy link
Copy Markdown
Contributor

One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates.

Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it.

If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures.

@github-actions github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Insufficient data

Not enough activity yet to make a reliable assessment.

View full analysis →

This is an automated analysis by AgentScan

Part of PyCalendar#876.

AI: Claude Opus 5.5

Prompt (summary): help draft an ical_value property for vTime following vDate.ical_value.

Output: The property, docstring, tests, and news entry in this commit. I reviewed the code, placed the files, fixed the test file location, and ran the full test suite locally.
@wmortenson199

Copy link
Copy Markdown
Author

Thanks for the automated check. I've shortened the description, updates the bio on my profile, and updated the commit message and news entry to fully disclose AI use per the project's AI policy. Happy to make any other changes.

Move the vTime news entry to 876.feature.3, since 876.feature.1 and
876.feature.2 are now used by vDatetime and vDuration.

AI: Claude Opus 5.5 (merge and conflict resolution), Claude Fable 5.2 (review and this commit message)

Prompt (summary): merge main into the branch and resolve the news file conflict; then check the branch against upstream main and the contribution docs, and add this disclosure.

Output: this merge commit. The news entry was renamed with its text unchanged, and there are no code changes. The review found the branch already up to date with upstream main, so no further merge was needed.
Comment thread news/876.feature.3 Outdated
@@ -0,0 +1 @@
Added the :attr:`vTime.ical_value <icalendar.prop.dt.time.vTime.ical_value>` property to :class:`vTime <icalendar.prop.dt.time.vTime>`, which returns the :class:`datetime.time` it represents. I used Claude Opus 5.5 to help verify the property, its tests, and to explain the contribution process for my first open source contribution, this was done after writing the code myself. @wmortenson199 No newline at end of file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AI disclosure here may not be that explicitly. However, it does not match the commit message.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I've updated the news entry so the AI disclosure is explicit and matches the commit message. The PR description now says the same, and the template sections are complete. Ready for another review when possible! thank you.

Part of PyCalendar#876.

AI: Claude Opus 5.5 drafted the revised wording of this news entry to match the commit message. I reviewed it.
@wmortenson199

Copy link
Copy Markdown
Author

The PR template sections are now complete, and the AI disclosure is consistent across the commit message, news entry, and description: I used Claude Opus 5.5 to draft the property, its tests, and the news entry, and I reviewed, placed, and tested the code myself. Could a maintainer take another look at the ai-suspicion label? Thanks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants