Repository navigation
Conversation
AI model: OpenAI GPT-6. AI use: drafted the INTERVAL getter, setter, deleter, and regression tests following the existing vRecur count/wkst patterns. Prompt summary: add an interval accessor with positive-integer validation, None/deletion semantics, and tests for parsing, mutation, invalid values, and iCalendar round-tripping. I reviewed the implementation and repository contribution policy.
|
Thanks for the pull request, @aspire488! A maintainer will review it shortly. |
Automation signalsActivity patterns show signs of automation. Evidence
Last 3 PRs: This is an automated analysis by AgentScan |
|
One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates. Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it. If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures. |
|
Thank oyu for your contribution. Please work on the unchecked items in the PR description. Additionally please link the related issue correctly. There is placeholder text within the tempalte to do that. |
|
Thank you for addressing the feedback. I'm curious, why you just used consistent naming for positiv eint requirement instead of explaining, why you did it that way. I was just curious why that happen. And it definetly looks like an agent who just works on feedback instead of a human contributing, to be honest. |
Thanks for asking. My reasoning was primarily consistency with the existing "vRecur" accessors, particularly "count", while keeping the validation specific to "INTERVAL". The distinction is that "COUNT" can be zero, whereas RFC 5545 specifies "INTERVAL" as a positive integer, so I deliberately reject zero and negative values. I followed the existing accessor conventions for reading the first stored value, handling missing values, and deleting the property. I should have explained that reasoning more clearly in the implementation rather than leaving the validation behavior to speak for itself. I appreciate you pointing this out. I'll make sure the reasoning is clearer in future contributions. |
angatha
left a comment
There was a problem hiding this comment.
This still needs a doc review. Can you please clean up the PR description.
angatha
left a comment
There was a problem hiding this comment.
Changes are fine. Just the dock review is missing
|
@stevepiercy Could you please take a look at the documentation for this PR? Angatha has approved the code changes, and mentioned that a documentation review is still missing. Thanks! |
stevepiercy
left a comment
There was a problem hiding this comment.
Maybe I'm doing something wrong, but I think this doesn't work as described in the docstrings. Would you please take a look, and let me know. Thank you!
|
Thanks for the review. I've updated the implementation:
The changes are pushed to the existing PR branch. CI is running against the updated commits. |
|
@aspire488 please run tests locally before pushing commits, and update your branch to |
stevepiercy
left a comment
There was a problem hiding this comment.
Docs look nice!
- https://icalendar--2066.org.readthedocs.build/en/2066/reference/api/icalendar.prop.recur.recur.html#icalendar.prop.recur.recur.vRecur.interval
- https://icalendar--2066.org.readthedocs.build/en/2066/reference/api/icalendar.prop.integer.html#icalendar.prop.integer.vPositiveInt
However, two of my comments were left unaddressed, and I found more possibly unreachable code. Would you please take care? Thank you!
|
Hi Steve, Apologies for leaving those comments unaddressed earlier, and thank you for taking the time to review the implementation so thoroughly. I've now gone through the outstanding feedback and pushed the requested updates:
I've also pushed the changes to the PR. The CI checks are currently running. Thanks again for your patience and for the detailed feedback! |
stevepiercy
left a comment
There was a problem hiding this comment.
The light bulb in my head finally turned on. I kept using the Property access method, not the Dictionary access method.
I made a few more suggestions to clarify things to the reader and developer. Would you please take care? Then I'll approve. Thank you!
|
Thanks, Steve! I've addressed all three suggestions:
The changes are pushed to the PR. Thanks for the detailed feedback! |
stevepiercy
left a comment
There was a problem hiding this comment.
I think we have a winner! Thanks for your collaboration and patience, @aspire488.
I'm going to turn it back over to @niccokunzmann and @angatha for a final review.
Linked issue
Description
Adds an "interval" property to "vRecur" for accessing the "INTERVAL" part of an iCalendar recurrence rule.
The accessor:
The change includes regression tests for parsing, assignment, deletion (including multi-value entries), invalid values, and iCalendar serialization. A separate changelog entry was added.
This implements only the "INTERVAL" accessor portion of #1851; it does not close the issue.
Checklist
Additional information
The implementation and regression tests were assisted by OpenAI GPT-6. I reviewed the changes against existing "vRecur" accessors and the project's contribution requirements. The test suite has not yet been run locally.