Repository navigation
feat(api): add basic and bearer auth for URL fetching - #164
Merged
Merged
Conversation
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /fetchJSON body instead of query params.GET /fetch?...would put credentials straight into gunicorn's stdout access log (--access-logfile -in the Dockerfile) on every deployment._ssrf.pydoesn't know about Basic/Bearer at all. It just attaches whatever headers it's given and drops them the moment(scheme, host, port)changes from the original request, checked fresh on every redirect hop.user:pass@hostembedded are rejected. Without that, a redirect to the same host with different userinfo would still pass the origin check and get the realAuthorizationheader forwarded.err.messagecontained'Failed to fetch', which is also literally how this app's own error details start ("Failed to fetch URL: ..."). Every real 401/404 was getting swallowed into a useless "Network error" message.Closes #79