Repository navigation
fix(api): prevent DNS rebinding SSRF in URL fetching - #162
Merged
Merged
Conversation
Documentation build overview
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SashankBhamidi
force-pushed
the
fix/dns-rebinding-ssrf-70
branch
from
September 12, 2026 01:20
92d293c to
4592956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/fetch and /fernet/{token} validated a URL's hostname before resolving DNS, so an attacker's domain could pass validation with a public IP and then resolve to a private one for the actual request.
Every hop now resolves DNS once, checks every address it returns, and pins the connection to one of them. New module webapp/_ssrf.py holds this logic; both endpoints share one fetch_with_pinned_redirects() helper instead of duplicating it. Address validation switched from a hand-maintained block list to an allowlist based on ip.is_global, since the old list missed IPv4-mapped IPv6 and a few other non-routable ranges.
Closes #70