Repository navigation
test: X- properties on the corpus alarms - #57
Merged
Merged
Conversation
The round-trip corpus carried X- properties on events, tasks and journals, but not on their alarms, so a backend dropping them from a VALARM passed the conformance suite. Both alarms now carry one, and a broken memory backend checks that the suite catches the loss. VTIMEZONE is left out on purpose: a server may replace it with its own, so verify does not compare it. Refs #15 Prompts: > [pick from the task list: "calendaring: round-trip fixture corpus > for the conformance suite"] > come again? ... What X-properties? (the task was already done, except > for some small nit, I needed a bit of explaination to understand the > issue) > ok [add X- properties to VALARM and VTIMEZONE] Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
test: X- properties on the corpus alarms
The round-trip corpus carried X- properties on events, tasks and
journals, but not on their alarms, so a backend dropping them from a
VALARM passed the conformance suite. Both alarms now carry one, and a
broken memory backend checks that the suite catches the loss.
VTIMEZONE is left out on purpose: a server may replace it with its
own, so verify does not compare it.
Refs #15
Prompts:
Assisted-By: Claude Opus 5.5
Reviewed-by: Tobias Brox tobias@redpill-linpro.com
Tested: full suite, and the corpus round trip on Bedework, Nextcloud,
Davis, Zimbra, CCS, Stalwart, Ox, Davical, SOGo, Cyrus, Baikal,
Xandikos and Radicale.
🤖 Generated with Claude Code