Repository navigation
Conversation
ecloud (Nextcloud) refuses MKCALENDAR with 429 after about 10 calendars an hour, and the suite makes one per test, so most tests failed there. A new hook, reuses_collections(), makes the suite keep each collection it makes and use it again by name, as it already does where collections cannot be deleted; only what the suite wrote is removed after a test. The test of making and deleting a collection still makes one per run, and the first run on an account a few more. The CalDAV tests turn it on where caldav's rate-limit hint gives create_calendar_per_hour, which the caldav PR python-caldav/caldav#871 adds for ecloud. With a caldav without it, nothing changes. Prompts: > [pick from the task list: "calendaring: conformance follow-up - > decisions and push after 2026-11-11 session"] > (on ecloud's calendar-creation rate limit making 174 tests fail) I > thought we already had a fix here, reusing calendars? > (on the options: a caldav hint, keying on the server name, or skipping > ecloud) We go for [a caldav calendar-creation rate-limit hint], > probably. I don't think we should have a probe for this. This means > it's not a "server-feature", but either a "client-feature" or > "server-observation" or something like that. > please fix it now Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs python-caldav/caldav#871 (the
create_calendar_per_hourhint) to take effect; with a released caldav the suite behaves as before, so CI should be green either way.Commit message: