Skip to content

Fix v2.0.0 regressions against current Cyrus - #88

Merged
SashankBhamidi merged 3 commits into
mainfrom
fix/v2.0.0-cyrus-regressions
Nov 3, 2026
Merged

SashankBhamidi merged 3 commits into
mainfrom
fix/v2.0.0-cyrus-regressions

Conversation

@SashankBhamidi

Copy link
Copy Markdown
Member

v2.0.0's tag push triggered an integration workflow I hadn't checked before release, and it failed. Current Cyrus rejects version (an earlier build required it), wants recurrenceRules plural instead of singular (Stalwart still wants singular), and now requires sendTo on every participant. Fixed all three: version omitted, recurrenceRule retries with the other spelling and converts shape, sendTo always sent.

Also fixed: Cyrus omits isDefault instead of sending false, so a single-address-book account never got flagged default. A crash on participants: None in _find_participant_id_by_email instead of raising notFound.

tests/docker/cyrus/docker-compose.yml was pinned to a different Cyrus digest than CI with the opposite version requirement, so local make test-integration would fail against a fix CI verified. Re-pinned to match.

Two tests had the bug reversed on them, Cyrus stopped dropping rel: enclosure attachments and stopped rejecting VirtualLocation.description. Updated to assert the real behavior.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.35691% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/calendaring_jmap/client.py 98.41% 0 Missing and 1 partial ⚠️
src/calendaring_jmap/tests/test_jmap_unit.py 99.56% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@SashankBhamidi
SashankBhamidi merged commit b52cc12 into main Nov 3, 2026
14 of 15 checks passed
@SashankBhamidi
SashankBhamidi deleted the fix/v2.0.0-cyrus-regressions branch November 3, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant