Verify The Island of Dr. Brain - #721
Open
tomojira wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Island of Dr. Brain, The (1992) (Sierra On-Line)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
I added instructions for reproducing
RESOURCE.CFG. It's needed in the DOSZ because the necessaryminHunkparameter won't be created byINSTALL.EXElater.Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
It isn't on GOG or Steam.
Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, I added it to
RESOURCE.CFG.Can DoDAT build the game from the install media?
Unfortunately no,
RESOURCE.000andRESOURCE.AUDare created during the installation process.If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
No, I added them.
Does the DOSZ run standalone?
Yes, after adding
RESOURCE.CFG.For CD games, can the game be set up to run without a CD mounted?
Not applicable. A CD image was actually included, but it wasn't necessary so I removed it.
Can the game benefit from using CHDtoOGG?
Not applicable.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
There is copy protection, but I have a feeling it's an integrated part of the game, like some other Sierra games. TDC notes don't mention cracks in any case.
Is the game running at the correct speed? Is CPU year specified?
No CPU setting was specified. I added
cpu_year: 1990to slow it down, which fixes a driver error when running the game. (previously this was bypassed by pressing ESC)Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes, but I updated it to use WAITMODECHANGE. I also added a longer WAIT for MT-32.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Yes, it's using "old". It still had the .dosz extension so I updated it to .dosx.
Does the game have General MIDI support?
Yes, but it was missing, I added it.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I enabled it.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Summary of changes
RESOURCE.CFGto DOSZ with embedded datacpu_year: 1990Unmentioned in the checklist: