Skip to content

Verify Castle of Dr. Brain - #720

Open
tomojira wants to merge 2 commits into
PureDOS:mainfrom
tomojira:castledrbrain
Open

Verify Castle of Dr. Brain#720
tomojira wants to merge 2 commits into
PureDOS:mainfrom
tomojira:castledrbrain

Conversation

@tomojira

Copy link
Copy Markdown
Contributor

Verifying Castle of Dr. Brain (1991) (Sierra On-Line)

Checklist

Have adequate installation instructions been provided to match any config files in the DOSZ?
I added instructions for reproducing RESOURCE.CFG. It's needed in the DOSZ because the necessary minHunk parameter won't be created by INSTALL.EXE later.

Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.

Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.

For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.

Is the entry in the right variant file (i.e. Freeware)?
Yes.

Have digital versions (Steam, GOG) been checked for matching?
The DOS version isn't on GOG/Steam according to the original PR.

Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, I added it to RESOURCE.CFG.

Can DoDAT build the game from the install media?
Yes.

If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.

Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.

Do the file timestamps match the installation media?
Yes.

Does the DOSZ run standalone?
Yes, after adding RESOURCE.CFG.

For CD games, can the game be set up to run without a CD mounted?
Not applicable.

Can the game benefit from using CHDtoOGG?
Not applicable.

Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.

Does the DOSC contain problematic data (i.e. copyright issue)?
No.

Does the DOSC have copy protection removed, if possible?
Unknown if this CD version has copy protection. Nothing appears at the beginning.

Is the game running at the correct speed? Is CPU year specified?
No CPU setting was specified. I added cpu_year: 1989 to slow it down, which seemed a bit better in the memory game at the beginning.

Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes. I added a longer WAIT to compensate for reducing the CPU speed, and even moreso for MT-32.

Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Yes, it's using "old". It still had the .dosz extension so I updated it to .dosx. It was also missing a RESOURCE.CFG with the MT-32 driver selected, so I added that too.

Does the game have General MIDI support?
No.

Is the game set up to run with the best quality graphics options by default?
Not applicable.

For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.

Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I enabled it.

Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.

Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.

Summary of changes

  • Added RESOURCE.CFG to DOSZ with embedded data
  • Added cpu_year: 1989
  • Added longer WAIT, especially for MT-32
  • Updated MT-32 extension to .dosx
  • Added config file to MT-32 option
  • Enabled direct mouse
  • Edited comments and links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant