feat(iso): dedicated ZLayer::SystemsModel variant - #185
Open
elasticdotventures wants to merge 5 commits into
Open
feat(iso): dedicated ZLayer::SystemsModel variant#185elasticdotventures wants to merge 5 commits into
elasticdotventures wants to merge 5 commits into
Conversation
Requirement/Decision/Cost content (ledgrrr#184) gets its own isometric layer rather than folding into the existing 6 or the still-unimplemented proposed Domain layer (docs/ontological-implementation-spec.md §6.1), per decision 2 in docs/systems-modeling-registry-rescope.md: independent toggle/color in the renderer over reusing an ontological-concepts layer. index=6, base_z=816.0 (continuing the existing 136.0 spacing), color #be185d (distinct from all 6 existing hexes). No HasVisualization impls wired yet for Requirement/Decision/Cost themselves — that requires also touching xtask's viz_manifest export + the checked-in viz-manifest.json per iso_objects.rs's own convention, tracked as a follow-on alongside task 6 (ledgerr-mcp/contract.rs wiring), not done here.
…inds' into feat/zlayer-systems-model-variant
elasticdotventures
marked this pull request as ready for review
August 22, 2026 13:09
…inds' into feat/zlayer-systems-model-variant
…inds' into feat/zlayer-systems-model-variant
…inds' into feat/zlayer-systems-model-variant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZLayervariant,SystemsModel, dedicated to Requirement/Decision/Cost content per decision 2 (independent layer, not folded into the existing 6 or the still-unimplemented proposedDomainlayer fromdocs/ontological-implementation-spec.md§6.1)index=6,base_z=816.0(continues the existing 136.0 spacing),color=#be185d(distinct from all 6 existing hexes),label="SystemsModel"ZLayertests and adds a dedicated test asserting the new variant is distinct fromPipelineand correctly spaced fromAttestationZLayer(mirroring the check done for task 3'sNodeType/ArtifactKindwidening) — none exist outsideiso.rsitself; all other references just constructZLayervalues, which is safe under enum growthNot done here (tracked as follow-on)
No
HasVisualizationimpls wired for theRequirement/Decision/Coststructs from ledgrrr#184 —iso_objects.rs's own doc comment requires every new impl there to also updatextask/src/viz_manifest.rs::export_viz_manifestand the checked-inui/docs/public/viz-manifest.json. That's a larger, separate change and naturally belongs alongside task 6 (wiring the new capability family intoledgerr-mcp/src/contract.rs), not task 4.Stacked on #184 (base branch
feat/requirement-decision-cost-kinds), which is stacked on #183.Test plan
cargo test -p ledger-core --lib iso— 17 passedcargo test -p ledger-core --lib— 181 passed, 1 ignoredcargo check --workspace --all-features— clean (1 pre-existing unrelated warning inledgerr-mcp/src/fbar.rs)ufo-types::isoclippy lint failures are pre-existing onmain, unrelated to this change (differentiso.rs, different crate)https://claude.ai/code/session_01XUAuQ6291UNn9sWcaviosB