Skip to content

Config: remove version id from response body #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nishika26 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −1
Open

Config: remove version id from response body #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/app/models/config/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ class ConfigVersionUpdate(SQLModel):


class ConfigVersionPublic(ConfigVersionBase):
id: UUID = Field(description="Unique id for the configuration version")
Copy link
Copy Markdown
Collaborator

@Ayush8923 Ayush8923 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirm, was this removed only because the config version did not require this API? Also, if it has been removed from here, then corresponding changes may also be required on the frontend side? otherwise, the frontend might crash.

Copy link
Copy Markdown
Collaborator Author

@nishika26 nishika26 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this version id is not used anywhere at all, users as well as the frontend only depends upon config id and version number

config_id: UUID = Field(description="Id of the parent configuration")
version: int = Field(nullable=False, description="Version number starting at 1")
inserted_at: datetime
Expand Down
Loading