Skip to content

fix(sdk): return transactionHash from cancelOrder method - #1983

Closed
Lesnak1 wants to merge 1 commit into
ProjectOpenSea:mainfrom
Lesnak1:fix/issue-1981-cancelorder-return-transaction-hash
Closed

fix(sdk): return transactionHash from cancelOrder method#1983
Lesnak1 wants to merge 1 commit into
ProjectOpenSea:mainfrom
Lesnak1:fix/issue-1981-cancelorder-return-transaction-hash

Conversation

@Lesnak1

@Lesnak1 Lesnak1 commented Aug 10, 2026

Copy link
Copy Markdown

Summary

Fixes #1981.

Ensures the singular cancelOrder method returns the transactionHash string, aligning its return interface behavior with cancelOrders.

Rationale

Allows developers to receive and track the transaction hash immediately after initiating single order cancellations.

Verification

  • Built locally via npm run build (tsc) without errors.
  • Verified against unit test suite (npm test): 791/791 tests passed cleanly.

@socket-security

socket-security Bot commented Aug 10, 2026

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Lesnak1
Lesnak1 force-pushed the fix/issue-1981-cancelorder-return-transaction-hash branch from ef2dadd to 49c1f75 Compare August 10, 2026 16:58
@ryanio

ryanio commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks @Lesnak1, appreciate you taking this on. It duplicates #1982, which landed the same fix for #1981 a couple of weeks earlier, so we've carried that one into our internal source repo with credit to its author.

The fix will go out in the next @opensea/sdk release. Closing this as a duplicate, and thanks again for the contribution.

@ryanio ryanio closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cancelOrder does not return the transaction hash unlike cancelOrders

2 participants