Fix floating-window duplicate-key crash; add mouse/keyboard action editors; fix InTimePeriod rule UI#86
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ButtonIdentries when building the lookup for layout ordering.TimePickercontrols show and update correctly.Description
FloatingWindowService.GetOrderedRows()by grouping_entries.ValuesbyButtonIdand using the first entry per id when creating the dictionary. (Services/FloatingWindowService.cs).KeyboardInputSettingswith a structuredActionslist andKeyboardActiontype to store per-stepType,KeyCode,KeyName, andInterval, while keeping the legacyKeyslist for compatibility. (Settings/KeyboardInputSettings.cs).SimulateKeyboardActionto play back per-stepActions(supportingPress,KeyDown,KeyUp) and to convert legacyKeysinto the newActionsformat as a fallback. (Actions/SimulateKeyboardAction.cs).ActionsandKeys. (Controls/SimulateKeyboardSettingsControl.cs).Settings.Actions. (Controls/SimulateMouseSettingsControl.cs).RuleSettingsControlBaseAXAML and event-drivenTimePickerLoaded/SelectedTimeChangedhandlers (pattern taken from ExtraIsland) so the control displays and syncsStartTime/EndTimecorrectly. (Controls/InTimePeriodRuleSettingsControl.axamland.cs).Testing
git diff --checkwhich reported no whitespace/merge problems and passed.dotnet build SystemTools.csproj -p:Platform=x64but the container environment lacked thedotnetSDK so a build could not be executed here (manual or CI build recommended).Actionslists are populated from recordings and that the keyboard playback code handles both the newActionsand legacyKeysfallback in code paths.Codex Task