Bug #15767: Cancel popup - bug design - #3927
Merged
Merged
Conversation
hazco75
added
bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe confirm dialog now uses fixed undo translation bindings. ChangesConfirm dialog updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes a localized adjustment to the confirmation dialog layout and size, with no actionable merge-blocking risk remaining beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
New Issues (14)Checkmarx found the following issues in this Pull Request
Fixed Issues (397)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
marob
requested changes
Aug 18, 2026
hazco75
force-pushed
the
bug_15767_design
branch
2 times, most recently
from
August 18, 2026 13:50
18c695c to
2078365
Compare
marob
requested changes
Aug 18, 2026
hazco75
force-pushed
the
bug_15767_design
branch
from
August 19, 2026 09:06
2078365 to
4b9c41b
Compare
marob
approved these changes
Aug 19, 2026
Salimdev
approved these changes
Aug 19, 2026
hazco75
added
the
CP V9.1
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3927-to-master_9.1.x
git worktree add --checkout .worktree/backport-3927-to-master_9.1.x backport-3927-to-master_9.1.x
cd .worktree/backport-3927-to-master_9.1.x
git reset --hard HEAD^
git cherry-pick -x 4b9c41b4360220adc49ecbd0c0d9337bb6a5e1fe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correction effectuée sur une pop-up de confirmation de fermeture de dialog :
Summary by CodeRabbit