fix profile selection - #579
Merged
Merged
Conversation
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
● fix(profile): tapping the active profile no longer does nothing
Selecting a profile on "Who's watching" often did nothing until you tapped several times.
The LaunchedEffect that navigates read navigateTriggered without it being one of its keys, so the tap never re-ran it — navigation relied on observing a change in activeProfile.id or isSwitchingProfile. Re-selecting the active profile changes neither: the id is unchanged, and isSwitchingProfile flips true
→ false within one frame, which the conflating StateFlow collapses before Compose reads it.
Surfaced by d9e49b1, which skipped the setActiveProfile disk write for the same profile — the write had incidentally kept the flag observable for a frame.
Fix: add navigateTriggered to the effect's keys. The !isSwitchingProfile guard is untouched, so real switches still defer until done.