Skip to content

Group 19hz markers by venue - #88

Closed
ProLoser wants to merge 5 commits into
mainfrom
copilot/fix-19hz-venue-grouping
Closed

ProLoser wants to merge 5 commits into
mainfrom
copilot/fix-19hz-venue-grouping

Conversation

@ProLoser

Copy link
Copy Markdown
Owner

Summary

  • Group events by venue rather than rounded coordinates, keeping unrelated venues separate even when they share coordinates.
  • Keep events without a venue separate and cover grouping and filtering with a regression test.

Some venue records contain only city-level coordinates, so separate markers can still overlap until their coordinates are corrected.

Validation

  • node --test 19hz/map.test.js 19hz/scripts/venues.test.js
  • node --check 19hz/map.js

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.2

🚀 View preview at
https://ProLoser.github.io/funcheapmap/preview/pr-88/

Built to branch gh-pages at 2026-11-17 01:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ProLoser

Copy link
Copy Markdown
Owner Author

@copilot this is covering up too many events. can we use the previous approach but reduce the radius so that separate buildings are not grouped together. it would be nice if grouping was recalculated on zoom

ProLoser and others added 2 commits November 17, 2026 01:51
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot this is covering up too many events. can we use the previous approach but reduce the radius so that separate buildings are not grouped together. it would be nice if grouping was recalculated ...

Updated in 2a2d176: markers now cluster within a smaller 16-pixel map-space radius and regroup after zoom changes, so nearby buildings separate as you zoom in.

@ProLoser

Copy link
Copy Markdown
Owner Author

@copilot actually, I think clustering by venue was the correct approach. I think the geocoding script is not using the full address and venue name. In addition to the city. I think it's only using the city. So I would like you to fix the geocoding script and go back to grouping by venue

ProLoser and others added 2 commits November 17, 2026 02:13
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot actually, I think clustering by venue was the correct approach. I think the geocoding script is not using the full address and venue name. In addition to the city. I think it's only using the...

Updated in b1e7d9a and cf5ddb5. Run the venue workflow with the new refresh option to retry existing city-only coordinates; unsuccessful lookups retain their previous coordinates.

@ProLoser

Copy link
Copy Markdown
Owner Author

@copilot

@ProLoser ProLoser closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants