Skip to content

Allow kong apikey when ds requirement disabled - #216

Merged
brucetony merged 1 commit into
mainfrom
fix-autostart-ds
Sep 22, 2026
Merged

brucetony merged 1 commit into
mainfrom
fix-autostart-ds

Conversation

@brucetony

@brucetony brucetony commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Improvements
    • Autostart now determines Kong-key requirements for each analysis:
      • Aggregator analyses skip Kong registration.
      • Data-required analyses always register.
      • Other analyses register only when project routes require it.
    • Projects without applicable routes can start without a Kong key.
    • If Kong cannot be checked, startup continues without a key.
    • Registration failures still prevent pod startup.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cf8e86b8-bb4f-4821-a322-3b856a519ddd

📥 Commits

Reviewing files that changed from the base of the PR and between d739aec and 746de04.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • .github/workflows/release.yaml
  • hub_adapter/autostart.py
  • tests/conftest.py
  • tests/test_autostart.py
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Autostart now selects Kong keys per analysis. Tests isolate settings and cover route, aggregator, lookup-failure, and registration-failure cases. The release workflow removes explanatory comments without changing behavior.

Changes

Autostart Kong selection

Layer / File(s) Summary
Kong-key selection and startup wiring
hub_adapter/autostart.py
register_and_start_analysis delegates key selection to kong_key_needed. Aggregators skip Kong, data-required nodes require Kong, and other nodes check project routes. Route lookup failures log a warning and continue without a key.
Optional registration test coverage
tests/conftest.py, tests/test_autostart.py
Tests use isolated settings and temporary state. Coverage verifies route-based registration, skipped registration, lookup failures, aggregator behavior, and failed registration handling.

Release workflow cleanup

Layer / File(s) Summary
Build-image comment removal
.github/workflows/release.yaml
Explanatory comments were removed from the build-image job. Workflow behavior is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant register_and_start_analysis
  participant kong_key_needed
  participant list_specific_project
  participant register_analysis
  participant send_start_request
  register_and_start_analysis->>kong_key_needed: determine Kong key requirement
  kong_key_needed->>list_specific_project: check project routes when required
  kong_key_needed-->>register_and_start_analysis: return key or "none_needed"
  register_and_start_analysis->>register_analysis: register analysis when required
  register_and_start_analysis->>send_start_request: start after registration succeeds
Loading

Merge Risk: ⚪ Minimal · up to 746de

No actionable merge-blocking risk remains in the reviewed change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: Kong API key registration when the data-store requirement is disabled.
Docstring Coverage ✅ Passed Docstring coverage is 94.44% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brucetony
brucetony merged commit 3158a0c into main Sep 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant