vulkan: extend PTQ1_0 fast integer-dot path to INTEL_XE1 iGPUs (Arrow Lake-H) - #274
Open
rriley-quorum wants to merge 1 commit into
Open
rriley-quorum wants to merge 1 commit into
rriley-quorum wants to merge 1 commit into
Conversation
… Lake-H) PR PrismML-Eng#238 gated the PTQ1_0 fast integer-dot shader on INTEL_XE2 classification (minSubgroupSize == 16). Intel Arc 140T (Arrow Lake-H, Xe-LPG+) reports minSubgroupSize == 8 and classifies as INTEL_XE1 instead, so it falls through to the blanket Intel-Windows opt-out and stays on the slow dequant path, even though the shader only needs integerDotProduct4x8BitPackedSignedAccelerated, which INTEL_XE1 classification already guarantees. Extends the existing check to also allow PTQ1_0 through under INTEL_XE1 when integer_dot_product is set. Measured on Intel Arc 140T (Arrow Lake-H, driver 101.8860), Ternary-Bonsai-2-27B-PTQ1_0: 1.3 -> 8.8 tok/s. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Code review from the Xe2/Xe3 side (Intel Arc B390, Panther Lake, classifies as
The one open item is correctness of the new path on an Xe1 part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR #238 gated the PTQ1_0 fast integer-dot shader on INTEL_XE2 classification (minSubgroupSize == 16). Intel Arc 140T (Arrow Lake-H, Xe-LPG+) reports minSubgroupSize == 8 and classifies as INTEL_XE1 instead, so it falls through to the blanket Intel-Windows opt-out and stays on the slow dequant path, even though the shader only needs integerDotProduct4x8BitPackedSignedAccelerated, which INTEL_XE1 classification already guarantees.
Extends the existing check to also allow PTQ1_0 through under INTEL_XE1 when integer_dot_product is set.
Measured on Intel Arc 140T (Arrow Lake-H, driver 101.8860), Ternary-Bonsai-2-27B-PTQ1_0: 1.3 -> 8.8 tok/s.
Additional information
Closes #270
Requirements