Skip to content

Remove Danger - #4106

Merged
DmitrySharabin merged 1 commit into
v2from
remove-danger
Sep 14, 2026
Merged

DmitrySharabin merged 1 commit into
v2from
remove-danger

Conversation

@DmitrySharabin

Copy link
Copy Markdown
Member

Removes the Danger workflow and dangerfile.

Its only output was a gzip size table for changed *.min.js files. No minified file has been tracked since minified output moved to a gitignored dist/ in 2022 (8ffd023):

$ git ls-files | grep -c 'min\.js$'
0

So getChangedMinifiedFiles() filtered on a permanently empty set, and every PR since has received the same ## No JS Changes comment.

Removing it also drops the repository's only pull_request_target workflow — the one trigger that gives a fork-initiated run a write-scoped token. That workflow was the subject of #4101; the reported attack path was not real (the PR branch was fetched but never checked out, so npm ci always read the base lockfile), but it did pass a fork-controlled branch name to git fetch as a positional argument, and git accepts option-shaped ref names:

$ git check-ref-format 'refs/heads/--upload-pack=sh'; echo $?
0

simple-git stays — benchmark/benchmark.js and scripts/create-changelog.js use it. danger and gzip-size are dropped.

file +
dangerfile.js 0 94
.github/workflows/danger.yml 0 22
eslint.config.mjs 0 8
package.json 0 2
.npmignore 0 1
package-lock.json 0 783

npm run lint:ci, npm test (8 passing), and npm run build all clean.

Closes #4101

🤖 Generated with Claude Code

https://claude.ai/code/session_01UnHFG3AFkeYWjrbo3m5nbb

Its only output was a gzip size table for changed `*.min.js` files, but no
minified file has been tracked since minified output moved to a gitignored
`dist/` in 2022 (8ffd023). Every PR since has received the same
`## No JS Changes` comment.

Removing it also drops the repository's only `pull_request_target` workflow,
which ran with a write-scoped default token and passed a fork-controlled
branch name to `git fetch` as a positional argument.

`simple-git` stays — the benchmark and changelog scripts use it.

Refs #4101

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Sep 14, 2026

Copy link
Copy Markdown

Deploy Preview for dev-prismjs-com ready!

Name Link
🔨 Latest commit 337c7a4
🔍 Latest deploy log https://app.netlify.com/projects/dev-prismjs-com/deploys/6aa7c98ee078950008211eaf
😎 Deploy Preview https://deploy-preview-4106--dev-prismjs-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown

No JS Changes

Generated by 🚫 dangerJS against 337c7a4

@DmitrySharabin
DmitrySharabin merged commit 4879cbb into v2 Sep 14, 2026
14 checks passed
@DmitrySharabin
DmitrySharabin deleted the remove-danger branch September 14, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SECURITY] GitHub Actions pull_request_target: attacker clone_url fetched + npm ci executes fork preinstall - GITHUB_TOKEN exfiltrated

1 participant