Remove Danger - #4106
Merged
Merged
Remove Danger#4106
Conversation
Its only output was a gzip size table for changed `*.min.js` files, but no minified file has been tracked since minified output moved to a gitignored `dist/` in 2022 (8ffd023). Every PR since has received the same `## No JS Changes` comment. Removing it also drops the repository's only `pull_request_target` workflow, which ran with a write-scoped default token and passed a fork-controlled branch name to `git fetch` as a positional argument. `simple-git` stays — the benchmark and changelog scripts use it. Refs #4101 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Danger workflow and dangerfile.
Its only output was a gzip size table for changed
*.min.jsfiles. No minified file has been tracked since minified output moved to a gitignoreddist/in 2022 (8ffd023):So
getChangedMinifiedFiles()filtered on a permanently empty set, and every PR since has received the same## No JS Changescomment.Removing it also drops the repository's only
pull_request_targetworkflow — the one trigger that gives a fork-initiated run a write-scoped token. That workflow was the subject of #4101; the reported attack path was not real (the PR branch was fetched but never checked out, sonpm cialways read the base lockfile), but it did pass a fork-controlled branch name togit fetchas a positional argument, and git accepts option-shaped ref names:simple-gitstays —benchmark/benchmark.jsandscripts/create-changelog.jsuse it.dangerandgzip-sizeare dropped.dangerfile.js.github/workflows/danger.ymleslint.config.mjspackage.json.npmignorepackage-lock.jsonnpm run lint:ci,npm test(8 passing), andnpm run buildall clean.Closes #4101
🤖 Generated with Claude Code
https://claude.ai/code/session_01UnHFG3AFkeYWjrbo3m5nbb