Skip to content

Narrow pointwise segmentation to temporary identities #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PraneethMerugu merged 1 commit into from
Sep 17, 2026
Merged

Narrow pointwise segmentation to temporary identities #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/execution/stage_program.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,8 @@ function _temporary_live_after(field::Field, stages)
return false
end

function _pointwise_segment_entries(inputs, entries, binding)
temporary = Set(semantic_identity(value.field) for value in binding.fields
if value.ownership isa _TemporaryOwnership)
Base.@noinline function _pointwise_segment_entries_from_temporary_identities(
inputs, entries, temporary_identities::Set)
launches = _AbstractStageLoweringEntry[]
index = 1
while index <= length(entries)
Expand Down Expand Up @@ -574,7 +573,7 @@ function _pointwise_segment_entries(inputs, entries, binding)
map(stage.publications) do publication
component = only(publication.components)
identity = semantic_identity(component.field)
elide = identity in temporary &&
elide = identity in temporary_identities &&
!_temporary_live_after(component.field, later)
elide || push!(retained, identity)
return elide ? _ForwardOnlyPointwise() :
Expand All @@ -589,6 +588,14 @@ function _pointwise_segment_entries(inputs, entries, binding)
return launches
end

function _pointwise_segment_entries(inputs, entries,
binding::_ValidatedStructuralBinding)
temporary_identities = Set(semantic_identity(value.field) for value in binding.fields
if value.ownership isa _TemporaryOwnership)
return _pointwise_segment_entries_from_temporary_identities(
inputs, entries, temporary_identities)
end

Base.@nospecializeinfer Base.@noinline function _stage_binding_slice(
validated::_ValidatedStructuralBinding, stage::Stage)
Base.@nospecialize validated stage
Expand Down
Loading