Repository navigation
perf: use SSE2 for CPC_TAKE_TILL_ONE_OF - #13
Merged
Merged
Conversation
This proves to be ~1.30 faster compared to current master
```
./bench/bench_regression.sh master build/csv_simd_demo
Summary
build/csv_simd_demo < bench/data/customers-1000000.csv ran
1.31 ± 0.06 times faster than /tmp/nix-shell-208285-0/tmp.FxzsLSSdS3/ref/build/csv_simd_demo
```
This doesn't seem to increase the performance, so it's just a refactor.
This allows us to remove usage of string.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proves to be ~1.30 faster compared to current master
Also allows us to remove the dependency on string.h
memchr.Disadvantage is that now we depend on
__builtin_ctz(only available on GCC/Clang), but I'm putting a fallback if unavailable.