Skip to content

fix: add explicit return types for public client APIs#684

Closed
miachillgood wants to merge 1 commit into
PostHog:mainfrom
miachillgood:codex/fix-public-api-return-types
Closed

fix: add explicit return types for public client APIs#684
miachillgood wants to merge 1 commit into
PostHog:mainfrom
miachillgood:codex/fix-public-api-return-types

Conversation

@miachillgood

Copy link
Copy Markdown
Contributor

Summary

  • annotate public module-level helpers and matching Client methods with their concrete return types
  • return None explicitly from capture_exception when exception capture itself fails so the annotation stays accurate
  • make the shutdown/flush/join public APIs clearer for static type checkers

Validation

  • python -m compileall posthog
  • python -m pytest -q (local environment is missing the repo's optional test dependencies, so full pytest collection could not complete here)

@miachillgood miachillgood requested a review from a team as a code owner June 19, 2026 12:07
@greptile-apps

greptile-apps Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix: add explicit return types for publi..." | Re-trigger Greptile

@marandaneto

Copy link
Copy Markdown
Member

pr is a bit outdated
also see #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants