-
Notifications
You must be signed in to change notification settings - Fork 70
fix: ignore version value in public API snapshot #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−7
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dfe2698
fix: ignore version value in public API snapshot
marandaneto 82e11fa
test: cover public API version placeholder
marandaneto b68fc26
fix: avoid griffe import during test collection
marandaneto f2aec3a
test: move public API script test out of package suite
marandaneto 45b5445
test: disable client atexit joins during tests
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #!/usr/bin/env python3 | ||
| """Tests for check_public_api.py.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import importlib.util | ||
| from pathlib import Path | ||
| from types import SimpleNamespace | ||
|
|
||
|
|
||
| SCRIPT_PATH = Path(__file__).with_name("check_public_api.py") | ||
|
|
||
|
|
||
| def load_check_public_api(): | ||
| spec = importlib.util.spec_from_file_location("check_public_api", SCRIPT_PATH) | ||
| assert spec is not None | ||
| assert spec.loader is not None | ||
|
|
||
| module = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(module) | ||
| return module | ||
|
|
||
|
|
||
| def test_attribute_details_uses_placeholder_values() -> None: | ||
| check_public_api = load_check_public_api() | ||
|
|
||
| for path, placeholder in check_public_api.ATTRIBUTE_VALUE_PLACEHOLDERS.items(): | ||
| obj = SimpleNamespace(path=path, annotation=None, value='"7.19.1"') | ||
| assert check_public_api._attribute_details(obj) == f"{path} = {placeholder}" | ||
|
|
||
|
|
||
| def main() -> int: | ||
| test_attribute_details_uses_placeholder_values() | ||
| print("check_public_api tests passed.") | ||
| return 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| raise SystemExit(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
| import posthog.client as client_module | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def disable_client_atexit_join(monkeypatch): | ||
| monkeypatch.setattr(client_module.atexit, "register", lambda *args, **kwargs: None) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.