Hide count badge on Runs inbox tab#2748
Conversation
The run count was noise rather than signal. Keep counts on Pull requests and Reports tabs, but stop showing the number on the Runs tab. Generated-By: PostHog Code Task-Id: d6796ead-a2fb-4d8a-a63f-3586a50c750f
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "Hide count badge on Runs inbox tab" | Re-trigger Greptile |
andrewm4894
added
the
Stamphog
The Runs tab no longer shows a count and nothing else consumed it, so remove `runs` from `InboxTabCounts` rather than carry an unused field. Also drops the `runs_count` analytics property that was only fed from it. Generated-By: PostHog Code Task-Id: d6796ead-a2fb-4d8a-a63f-3586a50c750f
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Coherent, low-risk cosmetic product change: suppresses the count badge on the Runs inbox tab and removes the now-unused runs field from the tab-count type, analytics schema, and computation logic. All test updates are consistent with the removal, and the optional analytics field deletion is non-breaking.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c04d2d6c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The leftover engagement test fixtures still passed `runs` in `tabCounts`, which are excess-property errors against the narrowed type and failed `@posthog/core` typecheck in CI before tests could run. Generated-By: PostHog Code Task-Id: d6796ead-a2fb-4d8a-a63f-3586a50c750f
|
Retaining stamphog approval — delta since last review classified as |
2 participants
Problem
The count badges on the Inbox tabs put numbers in people's faces. The PR and Reports counts are meaningful, but the Runs count is just noise.
Changes
Stop rendering the count badge on the Runs tab. Pull requests and Reports tabs keep their counts.
How did you test this?
Not run — single-line conditional change to badge rendering in
InboxTabBar.Automatic notifications
Created with PostHog Code from a Slack thread