Use white PostHog logo on sign-in button and tidy auth copy#2741
Draft
rafaeelaudibert wants to merge 1 commit into
Draft
Use white PostHog logo on sign-in button and tidy auth copy#2741rafaeelaudibert wants to merge 1 commit into
rafaeelaudibert wants to merge 1 commit into
Conversation
Adds a `mono` (forced white) variant to the Logo component and uses it for the logomark on the solid-accent auth button, replacing the colored icon. Also shortens the auth heading/button to "Authenticate with PostHog" and renames the region label to "Select your data region". Generated-By: PostHog Code Task-Id: 3eb5fe1a-84d2-4fe9-96e9-a2c855889c07
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "Use white PostHog logo on sign-in button..." | Re-trigger Greptile |
Member
Author
|
Requested by @corywatilo in Slack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The colored PostHog logo was being used on the solid-accent sign-in button, where it should never sit on a solid color background. The auth copy was also a bit verbose ("Sign in / sign up with PostHog") and the region label ("Pick where your data lives") implied the user could set their region there.
Changes
mono(forced solid-white) variant to theLogocomponent and use it for the logomark on the sign-in button, replacing the coloredposthog-icon.svg.How did you test this?
Ran Biome lint on the four changed files (clean) and typechecked
@posthog/ui— the edited files produce no new type errors (remaining errors are pre-existing unbuilt-dependency issues). Did not run the app.Automatic notifications
Created with PostHog Code from a Slack thread