redesign channels: single-column sidebar + full-width title bar#2730
redesign channels: single-column sidebar + full-width title bar#2730adamleithp wants to merge 3 commits into
Conversation
|
The button-variant trigger spans the full sidebar width, so binding the dropdown to --anchor-width stretched the menu and broke its layout. Pin a fixed width for the button variant; the item variant still matches its anchor. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2d8ca4d to
cfbd30a
Compare
|
Review agent failed — check the workflow run and re-apply the label to retry. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Bring back the Starred sidebar group removed in the channels redesign: starred channels list under a star-icon label, the rest under "Channels". Wrap each channel header row in a single quill ButtonGroup so the "# name" toggle joins with the hover actions (new task + options menu). Lift the options-menu open state so the actions stay visible while the menu is open, and reserve the name's trailing padding on hover or while open. Also: drop a stray "xxx" prefix in SectionBody, swap ScrollArea for a plain overflow div in WebsiteDashboard, and use rounded-sm on genui cards/tables. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This looks great. Two things: https://www.loom.com/share/95b33022b38c469480ccbfc2a9836289 |
Summary
Redesign of the Channels space UI — moves from a two-column layout (app rail + 260px channel pane) to a single self-contained sidebar under a full-width title bar.
Layout
ChannelsSidebar: one 220px column owning the left pane — workspace switcher (top), global nav, channel tree, Settings (pinned bottom). No app rail in this space.__root.tsxChannels-space layout reworked into a vertical shell with a full-width title bar carrying the PostHog mark (left-padded to clear the macOS stoplights). Drops the oldAppNav+ bordered 260px column.SidebarItemrows viaChannelsNav.Project switcher
ProjectSwitchergains a compactbuttontrigger variant (project name + chevron) for the Channels header, alongside the existingitemvariant used in the Code sidebar.buttonpins a fixedw-64(the full-width trigger would otherwise stretch the menu via--anchor-widthand break its layout);itemstill matches its anchor.Dashboards / data
DashboardsService.listnow filters a singlelistAll()bymeta.channelIdinstead of a per-channel server-side parent query, simplifying the path.domain-typesand the posthog-client.Test
pnpm --filter @posthog/ui typecheckclean.🤖 Generated with Claude Code