fix(agent): Don't let long running local checks prevent draft-PR creation

[mp-hog]

Problem

I ran into a problem that a PR wasn't created and subsequently the sandbox got killed without snapshot so that all work was lost. The PR creation was blocked because of long-running checks that were not needed as the coding task was verified already.

This PR modifies the PR-creation instructions to not gate draft PRs if the user requests to create one.

More context: https://posthog.slack.com/archives/C09G8Q32R6F/p1781593261186719

Changes

Added a reusable draftPrVerificationGuidance block to buildCloudSystemPrompt() in packages/agent/src/server/agent-server.ts and wired it into every PR-capable branch (review-first connected-repo, auto-publish, and the publish-enabled no-repository clone path). It instructs the agent to:

• Open the draft PR first, never gating creation on long-running local checks.
• Handle verification after the draft is open, without assuming the repo has CI: rely on CI if present, otherwise tell the user and offer to run the relevant checks as a follow-up task when the agent judges it warranted.

How did you test this?

• pnpm --filter @posthog/agent typecheck — passes
• biome check on both changed files — clean
• pnpm --filter @posthog/agent test agent-server.test.ts — 64/64 pass, including new assertions covering the guidance across the review-first, auto-publish, and no-repository branches (and its absence when createPr: false)

Automatic notifications

• Publish to changelog?
• Alert Sales and Marketing teams?

---

Created with PostHog Code

[github-actions]

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit c0ee634.}

[greptile-apps]

Comments Outside Diff (1)

1. packages/agent/src/server/agent-server.test.ts, line 1471-1479 (link)

   signal_report test missing new assertions — and both tests are candidates for parameterisation

   The Slack-origin test now asserts "Open the draft PR without blocking on long local checks" and "Opening the PR — do not block on long checks", but the equivalent signal_report test doesn't. Both origins hit the same shouldAutoCreatePr branch and produce identical prompts, so the gap is just a test-coverage hole. Per the team's preference for parameterised tests, the two auto-PR tests could be combined with it.each([{ origin: "slack" }, { origin: "signal_report" }], ...) and a shared shouldContain list — similar to the no-repository block above. That would keep the two paths in sync automatically.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: packages/agent/src/server/agent-server.test.ts
   Line: 1471-1479
   
   Comment:
   **`signal_report` test missing new assertions — and both tests are candidates for parameterisation**
   
   The Slack-origin test now asserts `"Open the draft PR without blocking on long local checks"` and `"Opening the PR — do not block on long checks"`, but the equivalent `signal_report` test doesn't. Both origins hit the same `shouldAutoCreatePr` branch and produce identical prompts, so the gap is just a test-coverage hole. Per the team's preference for parameterised tests, the two auto-PR tests could be combined with `it.each([{ origin: "slack" }, { origin: "signal_report" }], ...)` and a shared `shouldContain` list — similar to the `no-repository` block above. That would keep the two paths in sync automatically.
   
   How can I resolve this? If you propose a fix, please make it concise.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/agent/src/server/agent-server.test.ts:1471-1479
**`signal_report` test missing new assertions — and both tests are candidates for parameterisation**

The Slack-origin test now asserts `"Open the draft PR without blocking on long local checks"` and `"Opening the PR — do not block on long checks"`, but the equivalent `signal_report` test doesn't. Both origins hit the same `shouldAutoCreatePr` branch and produce identical prompts, so the gap is just a test-coverage hole. Per the team's preference for parameterised tests, the two auto-PR tests could be combined with `it.each([{ origin: "slack" }, { origin: "signal_report" }], ...)` and a shared `shouldContain` list — similar to the `no-repository` block above. That would keep the two paths in sync automatically.

_{Reviews (1): Last reviewed commit: "fix(agent): don't gate draft-PR creation..." | Re-trigger Greptile}