Skip to content

[codex] Make Pro guidance metadata-only #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danieliser wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Make Pro guidance metadata-only #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.1.0 - 2026-08-15

- Remove framework-rendered Pro offers; Popup Maker Core is now the sole renderer and decision-maker.
- Register optional `pro_feature` metadata with Core using only local plugin identifiers.
- Keep the bundled Core catalog authoritative so old extensions do not need an update.

## 1.0.6 - 2026-05-27

- Use "+" instead of "plus" in Pro panel upsell copy.
Expand Down
14 changes: 11 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,24 @@ Releases are tagged semver (`v1.0.0`, etc.).
- `Plugin\Core` — container bootstrap, `$this->core`, extension registration, license init
- `Services\License` — wraps `PUM_Extension_License`
- `Controllers\Assets` — DEWP/webpack asset registration from config
- `Controllers\Admin\ProUpsell` — Pro migration upsell when Pro is not active
- local Pro-feature metadata registration for Core-owned legacy guidance
- `Plugin\Controller` — controller base

## Extension config keys

| Key | Purpose |
|-----|---------|
| `asset_packages` | Webpack package definitions for `Assets` controller |
| `pro_upsell.feature_name` | Feature name in admin notice copy |
| `pro_upsell.utm_medium` | UTM medium for `generate_upgrade_url()` |
| `pro_feature.slug` | Stable Core legacy-catalog key; defaults to the extension slug |
| `pro_feature.feature_name` | Customer-facing feature name registered with Core |
| `pro_feature.priority` | Optional aggregation order |
| `pro_feature.plugin_basenames` | Optional historical basenames in addition to the current basename |
| `pro_feature.license_shortnames` | Optional historical local license option prefixes |
| `pro_feature.classes` / `constants` | Optional stable identifiers for active old versions |

The framework does not render offers or fetch offer data. Popup Maker Core owns
the bundled backwards-compatibility catalog, local state decisions, rendering,
and dismissal storage. The old `pro_upsell` config key is intentionally ignored.

Standard plugin keys (`slug`, `edd_id`, `name`, `version`, `text_domain`, `basename`, etc.) are required.

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "popupmaker/extension-framework",
"description": "Shared PHP framework for Popup Maker standalone Pro-tier extensions.",
"version": "1.0.6",
"version": "1.1.0",
"type": "library",
"license": "GPL-2.0-or-later",
"keywords": [
Expand Down
Loading