Repository navigation
feat: require the pollora/block-bindings package - #494
Merged
Merged
Conversation
Block Bindings live in pollora/block-bindings: the resolver, the sources Pollora ships, the discovery, the WordPress adapters, the editor script and the preview route, with their tests. The framework keeps the Laravel side: provider, config, the Laravel contracts' implementations, the doctor check and the commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the extraction of
pollora/block-bindings(Pollora/block-bindings v0.1.0, on Packagist).composer.json:pollora/block-bindings ^0.1.src/BlockBinding/{Application,Domain,UI}, the WordPress adapters, services and sources (24 files),resources/js/block-bindings.js(it ships with the package, which reads it from its own directory), and the 9 unit test files that went with them.Pollora\BlockBinding\Infrastructure\Laravel(provider,LaravelMethodInvoker,LaravelBindingEvents,LaravelPostFinder, doctor check, commands and stub),config/block-bindings.php, the resolver and provider tests that exercise the Laravel container, and the contract tests.surface.jsonis untouched and still passes.Checked: suite in sequence 1576 passed (1636 before, minus the tests that moved);
pint --teston the whole tree, PHPStan and Rector clean; the 28 captures of pollora-test (bindings resolved over REST for four sets, editor data,binding:list, concert pages, roles, doctor…) are identical to the references taken before the extractions, with Block Bindings served by the package.