Repository navigation
feat: require the pollora/roles package - #491
Merged
Merged
Conversation
Roles and capabilities live in pollora/roles: the definition builder, the registry, the compiler, the WordPress adapters and the discovery, with their tests. The framework keeps the Laravel side: provider, middleware, @ROLE directive, doctor check and commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the extraction of
pollora/roles(Pollora/roles v0.1.0, on Packagist).composer.json:pollora/roles ^0.1.src/Role/{Application,Domain}, the WordPress adapters andRoleDiscovery(28 files), and the 10 unit test files that went with them (they live in the package, now without Laravel).Pollora\Role\Infrastructure\Laravel(provider,EnsureUserHasRole,RoleDirective,RolesCheck, the six commands and stubs),config/roles.php,HasRolesand their tests, plus the contract tests.surface.jsonis untouched and still passes.Checked: suite in sequence, 1635 passed (1700 before, minus the tests that moved); PHPStan clean; Pint and Rector; the 28 captures of pollora-test (pages, REST, bindings, editor data, artisan outputs, roles:list and roles:show ×6, doctor, wp_user_roles) are identical to the references taken before the extraction, with Roles served by the package.