Repository navigation
feat: require the pollora/assets package - #486
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of pollora/assets (plan: .claude/plans/assets-package.md): the asset classes leave the framework for pollora/assets v0.1.0, which the framework requires. Class names do not change.
Moved to the package (20 files, and the 40 tests that go with them):
AssetManager,AssetRegistrationService,AssetRetrievalService,MissingBuilds,AssetContainer,InMemoryAssetRepository,AssetEnqueuer,AssetFile,MissingBuildNotice, the domain models, contracts (ViteManagerInterface,ViteManagerFactory,RuntimeContext,PublicPath…) and exception.Stays here:
AssetServiceProvider, the Laravel implementations of the three contracts (Asset/Infrastructure/Laravel/),ViteManager(Laravel's Vite) andRootAssetManager, theAssetfacade, the container contract test and theViteManagertests.One change in behaviour kept on purpose:
MissingBuildNoticetakes its doctor command as an argument (the package says nothing of Artisan); the provider passesphp artisan pollora:doctor, so wp-admin shows the same text.How it was checked