Repository navigation
test: pin the URLs each asset container resolves, in build and hot - #484
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of pollora/assets (plan: .claude/plans/assets-package.md): a contract test written before the extraction, so it can only break if behaviour changes.
Real containers (theme, plugin, module, root,
{parent}.blocks), realViteManager, manifests and hot files under public/. Pins: container names and config (hot file, build dir, manifest, base path = the layout @pollora/vite-config builds to), build URLs (js + css, base path, blocks container with empty base path), three dev servers at once with one container left on its build, Vite client per server, missing build, unknown container.Checked by mutation: a wrong base path (5 failures) and no clone of Laravel's Vite singleton (6 failures) are caught. 13 tests, 37 assertions. The two failures left in this area (
MissingBuildNoticein ddev,ModuleViewPathsTestin a full run) fail without this file too.Companion: .claude/plans/assets-golden (rendered HTML of pollora-test, build and hot) for the before/after diff.