Repository navigation
feat: require pollora/hook 2.0 - #474
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of the pollora/schedule plan, framework side. Needs pollora/hook v2.0.0 (released) and pollora/schedule v0.1.2.
pollora/hook ^2.0: asynchronous actions queue through the WP-Cron and Action Scheduler drivers of pollora/schedule.Async\Drivers\WpCronDriverandActionSchedulerDriverare gone with no alias; the framework never used them.->async(),#[Async],Async::fake(),via()and their options are unchanged, work queued by 1.x runs once the upgrade is in, and thequeuedriver (QueueDriver) is untouched.AsyncInspector::overdueCronEvents()no longer counts the events Action Scheduler keeps: thecronoption has indexed them, with adriverkey, since feat: choose the scheduling driver, list and migrate scheduled events #470, sopollora:doctorwould have called them overdue WP-Cron events.use_laravel_schedulerandQueueDriverstay for step 5.Checked on pollora-test with hook 2.0 linked: 3 messages queued under 1.4.1 run under 2.0, and with the site on Action Scheduler
via('wp-cron')stays an unmarked WP-Cron event.