Repository navigation
ci: PHP 8.2 to 8.4 matrix, lowest dependencies, enforced code style - #14
Merged
Merged
Conversation
…ecked), document the checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #13.
Matrix (
testsjob): PHP 8.2, 8.3, 8.4 with the highest dependencies, plus PHP 8.2 with--prefer-lowest. Each leg runs the tests and, as a separate step, the documentation examples.Style (own job, PHP 8.4):
pint --testnow fails the build. It used to runpintwithout--test, which fixes silently and never failed. Four files that were not formatted are fixed (style only: spacing and docblock alignment, no code change).Also:
actions/checkoutv3 to v4, no coverage driver (nothing used it),laravel/pintfloor raised to^1.30.How it was validated: I ran each job in a clean container (fresh source export, no
vendor, nocomposer.lock, as on CI): 8.2, 8.3, 8.4 highest and 8.2 lowest all pass (242 tests + 75 documentation examples), andpint --testpasses with Pint 1.30.0, 1.30.4 and 1.32.1. Pint 1.13.0, the old floor, formats differently, hence the new floor.PHP 8.5 is not in the matrix on purpose: the dev dependencies do not install on it (
paratest 7.4requires PHP 8.2 to 8.4, pulled in by Pest 2). With the platform check ignored, the whole suite passes on 8.5.11 and no deprecation comes fromsrc/ortests/(they all come from Pest 2 invendor/). Supporting it in CI needs a Pest upgrade.