Repository navigation
feat: CommentQuery (WP_Comment_Query) - #10
Merged
Merged
Conversation
- CommentQuery reusing metaQuery(), dateQuery(), MetaField, limits and paging concerns - OrdersByMap concern shared by UserQuery and CommentQuery - terminals: first, ids, count, exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9.
New
CommentQuerybuilder forWP_Comment_Query.metaQuery(),dateQuery(),MetaField,LimitsResultsandPagedResultsare reused as is;orderBy()as a field => direction map is extracted to theOrdersByMapconcern shared withUserQuery.All documented parameters are covered, except top-level
order(theorderbymap carries one direction per field).get(),first(),ids(),count(),exists()(run on a copy)status => all(hold + approve, no spam/trash) andno_found_rows => trueare kept and documented, unlike the 'no constraint' defaults ofPostQuery/TermQuery, since listing spam by default would be unsafePest: 201 passed.