Repository navigation
refactor(azure)!: retire azure.members.create and setAssocNumber - #127
Conversation
The dashboard now admits soci and changes member numbers through soci.members.admit and soci.members.setNumber (PoliNetworkOrg/admin#155), which keep the Libro Soci in step with Microsoft 365. azure.members is left read-only, with getAll. The router tests were the only coverage of the shared lock and pending-number cache in member-writes.ts, which soci.* still uses, so their scenarios move to direct tests of that module, along with the check that logged errors redact email addresses. BREAKING CHANGE: azure.members.create and azure.members.setAssocNumber are removed. Use soci.members.admit and soci.members.setNumber. Closes #122
|
No actionable comments were generated in the recent review. WalkthroughThe Azure members router now exposes only directory reads. Admission and member-number changes are identified as Soci procedures. Tests cover Entra-side write serialization and verify the remaining Azure member procedure. ChangesAzure member write retirement
Possibly related PRs
Change: Other Merge Risk:
|
Resolve the conflicts with main: - azure.members is read-only on main (#127): take main's router and tests; the audit annotations for create/setAssocNumber go with them. - Renumber the audit events migration to 0040, after main's 0033–0039. The SQL is unchanged; drop common_audit_events on a database that ran the old 0033 before migrating again. Declare how main's new mutations are recorded, so the router walk passes: - soci.*: minimal, naming the socio by member number; the Libro Soci keeps its history in soci_activity and its inputs carry personal data. - regulations.*: full, keeping only reference fields (ids, states, roles, titles), never comment bodies, quotes, delibere or notes. collabTicket is not recorded: it hands out a connection ticket and changes nothing. - web.documents.*: full. - Add regulations and soci to the audit.list area filter. Also restore the People target's validated fallback on the input id, which the autofix in b2569ac had dropped while its test still expected it.
Closes #122: the last item, retiring the old write procedures now that the dashboard has switched to
soci.members.*(PoliNetworkOrg/admin#155, PoliNetworkOrg/admin#158).Changes
azure.membersis read-only: onlygetAllstays.createandsetAssocNumberare removed. Their replacements aresoci.members.admitandsoci.members.setNumber, which also write the Libro Soci.src/azure/member-writes.ts(the write lock and pending-number cache), whichsoci.*still uses. Their scenarios move totests/azure-member-writes.test.ts, which tests the module directly. TurningrememberNumberinto a no-op makes 4 of them fail.tests/idp-router.test.tsnow asserts thatazure.members.getAllis the onlyazure.members.*procedure.Deploy
azure.members.getAll.azure:members:createandazure:members:writepermissions in Auth (each granted by two roles) are no longer used by anything here and can be removed.Checks
tsc,biome check,vitest(305 passed, 11 skipped: the Postgres suites, which need a database) andbuild:npmpass locally.