Skip to content

🛡️ Sentinel: Fix exception details leakage in login_required decorator - #15

Draft
Pmaster-dev wants to merge 2 commits into
copilot/restructure-repo-into-prod-devfrom
sentinel/fix-auth-info-leakage-8388778677498683575
Draft

🛡️ Sentinel: Fix exception details leakage in login_required decorator#15
Pmaster-dev wants to merge 2 commits into
copilot/restructure-repo-into-prod-devfrom
sentinel/fix-auth-info-leakage-8388778677498683575

Conversation

@Pmaster-dev

Copy link
Copy Markdown
Owner

🛡️ Sentinel: Fix exposed exception details in authentication errors

Vulnerability

In auth/utils.py, when login_required failed due to an exception, the JSON error response included 'details': str(e), exposing internal implementation details and raw error messages to unauthenticated users.

Fix

  • Removed 'details': str(e) from the 401 response payload.
  • Added internal exception logging using logger.exception.
  • Added unit tests in tests/test_auth.py to verify that unauthorized requests return standard error responses without leaking exception details.

PR created automatically by Jules for task 8388778677498683575 started by @Pmaster-dev

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant