π‘οΈ Sentinel: Fix error detail leakage in login_required decorator - #14
Conversation
Sanitize 401 response in auth/utils.py to avoid leaking sensitive internal exception details to unauthenticated callers. Log error internally instead. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sanitize 401 response in auth/utils.py to avoid leaking sensitive internal exception details to unauthenticated callers. Log error internally instead. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
π¨ Severity: MEDIUM
π‘ Vulnerability
auth/utils.pypreviously includedstr(e)in the 401 Unauthorized response body when authentication failed in thelogin_requireddecorator.π― Impact
Exposing exception details can leak database state, internal system information, stack frames, or connection details to unauthenticated attackers.
π§ Fix
login_requiredto log the authentication error internally on the server side using standardlogger.error.{"error": "Unauthorized"}without leaking internal exception details.tests/test_auth_utils.pyverifying that exception details are omitted from the response.β Verification
Ran
PYTHONPATH=.:src python3 -m pytest(3 passed) andPYTHONPATH=src pylint src/automation src/handoff auth --fail-under=7.0(rated 7.98/10).PR created automatically by Jules for task 12957691815833607693 started by @Pmaster-dev