Skip to content

πŸ›‘οΈ Sentinel: Fix error detail leakage in login_required decorator - #14

Draft
Pmaster-dev wants to merge 2 commits into
copilot/restructure-repo-into-prod-devfrom
sentinel/prevent-auth-error-detail-leakage-12957691815833607693
Draft

πŸ›‘οΈ Sentinel: Fix error detail leakage in login_required decorator#14
Pmaster-dev wants to merge 2 commits into
copilot/restructure-repo-into-prod-devfrom
sentinel/prevent-auth-error-detail-leakage-12957691815833607693

Conversation

@Pmaster-dev

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM

πŸ’‘ Vulnerability

auth/utils.py previously included str(e) in the 401 Unauthorized response body when authentication failed in the login_required decorator.

🎯 Impact

Exposing exception details can leak database state, internal system information, stack frames, or connection details to unauthenticated attackers.

πŸ”§ Fix

  • Updated login_required to log the authentication error internally on the server side using standard logger.error.
  • Sanitized the JSON response to return {"error": "Unauthorized"} without leaking internal exception details.
  • Added unit tests in tests/test_auth_utils.py verifying that exception details are omitted from the response.

βœ… Verification

Ran PYTHONPATH=.:src python3 -m pytest (3 passed) and PYTHONPATH=src pylint src/automation src/handoff auth --fail-under=7.0 (rated 7.98/10).


PR created automatically by Jules for task 12957691815833607693 started by @Pmaster-dev

Sanitize 401 response in auth/utils.py to avoid leaking sensitive internal
exception details to unauthenticated callers. Log error internally instead.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sanitize 401 response in auth/utils.py to avoid leaking sensitive internal
exception details to unauthenticated callers. Log error internally instead.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant