SPEC 7.6: the reconnect Gap is closed by plugrl-env-client#15; a dated correction in its place - #12
Merged
Merged
Conversation
… correction in its place The Gap said plugrl-env-client resent held feedback after a plugrl-server-stop close with --reconnect-on-server-stop. #15 removed that path, and also fixed a second violation the probe checker found that the Gap never mentioned: chunks in flight kept executing after a reconnect and their feedback went to the new connection. The correction says both, and which check now holds the client to the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPEC 7.6 has a Gap saying
plugrl-env-clientresent held feedback after aplugrl-server-stopclose when run with--reconnect-on-server-stop. plugrl-env-client#15, now merged, removed that path:feedback()never reconnects, and the rollout drops every chunk in flight.The Gap was also incomplete. The probe checker found a second violation it did not mention: after any reconnect, chunks in flight kept executing, and their feedback went to the new connection. #15 fixed that too.
This replaces the Gap with a dated correction that says both, and names the check that now holds the client to the rule,
plugrl-conformance --probe --scenario resync. plugrl-env-client#17 runs that check in its CI. No normative text changes.