fix: guard nginx reload when sudo is unavailable#3
Open
shanzez wants to merge 1 commit into
Open
Conversation
nginx.sh always called `sudo nginx -s reload`, which fails on hosts where the script already runs as root and `sudo` is not installed (common in minimal/root container environments). Run `nginx -s reload` directly when already root, fall back to `sudo` when available, and otherwise print a clear hint instead of failing. Fixes the case reported upstream in huly-selfhost#277. Signed-off-by: Exaviz <info@exaviz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nginx.shunconditionally runssudo nginx -s reload. On hosts where the script already runs as root andsudois not installed (common in minimal or container environments), that fails withsudo: command not found.This change:
nginx -s reloaddirectly when already root (nosudoneeded),sudo nginx -s reloadwhensudois available,Focused one-block change in the existing style;
shellcheck-clean on the changed lines. Fixes the case reported upstream in huly-selfhost#277.Contributed by Exaviz (exaviz.com).