fix(xlsx): 셀 타입 처리 (날짜·숫자 보존) + 실파일 검증#11
Merged
Conversation
"제대로 검증했냐" 지적에 따라 데이터 타입 엣지케이스와 실제 xlsx 파일로 재검증: - 날짜: '2026-06-01 00:00:00' → '2026-06-01' (시간 0 이면 날짜만). - set_cell: 깔끔한 숫자(금액 '3,000,000'→3000000)는 숫자형으로 기록해 Excel 수식/합계가 살아있게. 전화·사번·우편번호(대시·선행 0)는 문자로 보존(_maybe_number 가드). 기존엔 항상 문자로 써서 금액 셀이 텍스트가 됐음. - 실제 xlsx 5종(calamine 테스트셋, 다중 시트 6개 포함) load/inspect/편집/round-trip 전부 무크래시 확인. - 회귀 테스트(test_xlsx_value_typing) 추가. 78개 통과. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
데이터 타입 엣지케이스·실제 xlsx 파일로 재검증 후 수정. 날짜 시간 제거, set_cell 숫자 보존(금액)/문자 유지(전화·우편), 실파일 5종 무크래시. 78개 통과.
🤖 Generated with Claude Code