Repository navigation
Make boolean arguments keyword-only in the decommutator - #81
Merged
Merged
Conversation
Positional boolean arguments make call sites hard to read (e.g., read_file(path, True, False)). Requiring them to be passed by name lets us drop the FBT001/FBT002 suppressions, and a new test keeps the decommutator from regressing. In swp_spc_l0_to_l05.main and _get_layout_sc, the arguments apidreq and filename follow boolean arguments, so they are now keyword-only as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes every
boolargument inpyfaradaycup.decommutatorkeyword-only and removes the now-unneededFBT001/FBT002suppressions.This is a breaking change for code that passes booleans positionally to the public functions
read_file,read_file_sc, andswp_spc_l0_to_l05.main; all call sites in this repository already use keywords. Becauseapidreq(inswp_spc_l0_to_l05.main) andfilename(in_get_layout_sc) follow boolean arguments, they are now keyword-only too.🤖 Generated with Claude Code