Repository navigation
Run the headless Jolt tests on the engine test framework (PH-F36) - #3
Merged
Merged
Conversation
… with stacking, layer, trigger and query checks and open-bug reporting (PH-F36)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the headless Jolt tests (PH-F36, first slice) a real gate:
JoltTestnow runs on the engine test framework, passes on Windows and Linux, and is picked up by the engine repository's "Build and test" workflow.Changes
Tests/)JoltTests.exeharness becomesJoltTestonplTestFramework, the framework CoreTest and RendererTest use. Same flags, JSON report, file and line on failures and a real shutdown, so it works on Linux too.OpenDefect("PH-B14", ...). They warn and are listed at the end of the run, and-joltStrictDefectsmakes them fail. Today: PH-B12, PH-B13, PH-B14, PH-B15, PH-B32 and one unlisted gap (a sleeping box is not woken when the body under it is deleted).jolt-tests.ymlis manual only: it waited 24 hours for a self-hosted runner that does not exist on every run so far.!Bcommits)JoltJobSystem: the destructor waits for the task groups of started jobs. The framework shuts core systems down after each sub-test, destroying the job system while a worker thread was still running the last task's completion callback. On Linux that crashed about 1 run in 4.-Wl,-Bsymbolicfor the plugin on Linux: a host that also contains Jolt (the test executable) otherwise takes over the plugin's calls into Jolt, with its own copy of Jolt's global state.!B Bind Jolt cloth materials in mesh render datais cherry-picked from !B Bind cloth materials after loading GPU material data #2 because the engine's pin already depends on it. Drop it here if !B Bind cloth materials after loading GPU material data #2 lands first.Tested locally
JoltTest Passed 0Not run
Need help on this PR? Tag
@codesmith-botwith what you need.