Skip to content

Hopefully fixed afk tracking and removed ROBLOX_WORKSPACE_REDIRECTID - #197

Merged
BuddyWinte merged 2 commits into
PlanetaryOrbit:mainfrom
breadddevv:main
Aug 8, 2026
Merged

Hopefully fixed afk tracking and removed ROBLOX_WORKSPACE_REDIRECTID#197
BuddyWinte merged 2 commits into
PlanetaryOrbit:mainfrom
breadddevv:main

Conversation

@breadddevv

@breadddevv breadddevv commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Thank you for contributing to Orbit! 🐈

Before submitting, please make sure you have read the Contributing Guide.

Description

I've changed the way the tracker awaits till it can flag the user as AFK and removed the row ROBLOX_WORKSPACE_REDIRECTID as it isn't a required variable in README.md

Type of Change

  • [ x ] Bug fix
  • New feature
  • Enhancement
  • Documentation
  • Refactor
  • Performance improvement
  • Dependency update
  • Other

Testing

Describe how you tested your changes.

  • [ x ] Tested locally (under roblox studio)
  • Tested using Docker
  • Tested database changes (if applicable)

Checklist

  • [ x ] I have read the contributing guidelines.
  • [ x ] My changes follow the project's style guidelines.
  • [ x ] I have tested my changes.
  • [ x ] I have updated documentation if needed.
  • [ x ] This PR does not contain unrelated changes.

Additional Notes

N/A

Summary by CodeRabbit

  • New Features

    • Improved AFK detection with periodic activity checks.
    • Reduced the default AFK threshold from two minutes to one minute.
    • Added a configurable polling interval for AFK checks.
    • Player movement now immediately updates activity status.
  • Documentation

    • Removed the obsolete Vercel workspace redirect setting from deployment documentation.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@breadddevv, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fc756074-ba79-4beb-bb69-03707cb76bb3

📥 Commits

Reviewing files that changed from the base of the PR and between 2c0ef2f and fc5f55a.

📒 Files selected for processing (1)
  • Orbit-activity.rbxmx
📝 Walkthrough

Walkthrough

Orbit activity tracking replaces delayed AFK checks with configurable polling, lowers the AFK threshold to one minute, and removes obsolete state and heartbeat settings. The README removes an obsolete deployment environment variable.

Changes

AFK tracking

Layer / File(s) Summary
AFK configuration and state
Orbit-activity.rbxmx
Adds afkPollInterval, reduces minutesTillAFK to one minute, and removes obsolete heartbeat and pending-check state.
AFK polling and activity handling
Orbit-activity.rbxmx
Movement activity updates state directly. A periodic task marks idle online players as AFK. Remote activity uses the updated threshold.

Deployment documentation

Layer / File(s) Summary
Deployment variable documentation
README.md
Removes the ROBLOX_WORKSPACE_REDIRECTID environment variable and workspace redirection description.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AFK polling task
  participant PlayerState
  participant AFK state
  AFK polling task->>PlayerState: Check tracked online players
  PlayerState->>AFK state: Compare idle time with minutesTillAFK
  AFK state-->>PlayerState: Mark idle players as AFK
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies both main changes: AFK tracking updates and removal of ROBLOX_WORKSPACE_REDIRECTID.
Description check ✅ Passed The description explains both changes, identifies the change type, documents local testing, and includes the required checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Orbit-activity.rbxmx`:
- Around line 590-592: Update the PlayerData iteration condition in the AFK
polling loop to also require isUserTracked(Player), so AFK state updates and
logs only occur for tracked, online, non-AFK players.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60fb1b2f-70d7-427b-a2f1-cb768e3ac97c

📥 Commits

Reviewing files that changed from the base of the PR and between 28db83a and 2c0ef2f.

📒 Files selected for processing (2)
  • Orbit-activity.rbxmx
  • README.md
💤 Files with no reviewable changes (1)
  • README.md

Comment thread Orbit-activity.rbxmx Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@BuddyWinte BuddyWinte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BuddyWinte
BuddyWinte merged commit d9ce9e8 into PlanetaryOrbit:main Aug 8, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants