You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
OpenAPI doc: regenerate with the json-schema fix for Unix-second timestamps #397
OPENAPI_DOC.yml still documents the Unix-second timestamps as date-time strings. PlaceOS/rest-api#469 fixed the same problem in rest-api with json-schema 2.1.2, ActiveModel 4.7.2 and placeos-models 9.123.6. This repository locks json-schema 2.1.1, ActiveModel 4.7.1 and placeos-models 9.123.5 (shard.lock). An update of the three shards and a new document should fix it here too.
I compared the replies of a local stack with the document. These fields are date-time in the document, but the API sends integers:
created_at and updated_at of Asset, AssetCategory, AssetPurchaseOrder, AssetType, Attendee, Booking, ControlSystem, EventMetadata, Guest, Survey, Survey.Answer, Survey.Invitation, Survey.Question and Zone
GET /api/staff/v1/calendars/availability sends 204 No Content with no body when there are no calendars to check (calendars.cr#L98). The document has only a JSON 200 for success. A 200 with [] would match the document.
The last commit that changes OPENAPI_DOC.yml is 8b4fb62 (21 October). On master, the fields of the list above (for example Booking.created_at) are still format: date-time. The ts-client generator checks this on each run, and it still finds date-time on all of them.
To close this point, regenerate OPENAPI_DOC.yml with the new shards and commit it.
The other two points are not changed:
calendars/availability still sends 204 when no calendars match (src/controllers/calendars.cr:98), and the document says 200.
Activity
MrYuion commentedon Nov 19, 2026
Note
🤖 Claude Opus 5.5 responding on behalf of MrYuion
The shard update is done, but
OPENAPI_DOC.ymlis not regenerated yet, so the time fields in the document are still wrong.shard.lockto json-schema 2.1.2, active-model 4.7.2 and placeos-models 9.123.6, the same versions as fix(openapi): document Unix-second timestamps as integers rest-api#469.OPENAPI_DOC.ymlis 8b4fb62 (21 October). On master, the fields of the list above (for exampleBooking.created_at) are stillformat: date-time. The ts-client generator checks this on each run, and it still findsdate-timeon all of them.To close this point, regenerate
OPENAPI_DOC.ymlwith the new shards and commit it.The other two points are not changed:
calendars/availabilitystill sends 204 when no calendars match (src/controllers/calendars.cr:98), and the document says 200.ignore_deserialize. See OpenAPI doc leaves out read-only fields and types some strings as object rest-api#470.