Skip to content

Verify domain isolation in staff APIs #396

Open

Description

@stakach

Verify Staff API’s existing domain isolation while preserving its authenticated domain/calendar model.

Plan: PlaceOS/rest-api#463. Baselines: #390 and PlaceOS/models#332. Owner: stakach. Steve confirmed on 2026-11-16 that Staff API should continue using the domain. This work is independent of REST organisation selection.

  • Add regression coverage for unchanged Host/JWT matching, host/email-domain Tenant resolution, bookings/events/guests and existing delegated/application credentials.
  • Do not add organisation_id resource selection, organisation discovery aliases or cross-organisation calendar credential switching to Staff API.
  • Audit direct system/zone/asset/user references, spaces/staff fallback queries, batches and background jobs against the existing domain/tenant contract; fix demonstrated isolation failures with regression tests first.
  • Revalidate changed Tenant domain and referenced resources; preserve explicitly authorised cross-domain tenant administration.
  • Require partner_staff for management structural reach; retain exact authority/operation scope in tenant administration grants.
  • Preserve guest/public domain restrictions and existing Staff MCP/card context.
  • Run appropriate sequential local specs and GitHub CI; update documentation only for any demonstrated domain-isolation fixes.

REST organisation selection is tracked separately at PlaceOS/rest-api#464 and is not a dependency. No new feature implementation starts during the current audit/planning task.

Activity

  1. added this to the Multi-tenancy milestone on Nov 16, 2026
  2. self-assigned this
    on Nov 16, 2026
  3. changed the title [-]Apply selected organisation across staff APIs[/-] [+]Verify domain isolation in staff APIs[/+] on Nov 16, 2026
  4. stakach commented on Nov 17, 2026

    @stakach
    MemberAuthor

    Final verification is complete. All required checks are green on the four current heads, including each compiler variant and all current-head multiarch image builds:

    • Models 716ca76: CI, 970 examples each.
    • REST 1507d3a: CI, 1,538 examples each; image.
    • Staff a9b8a21: CI, 654 examples each plus browser checks; image.
    • Init 2a986f8: CI, 18 examples each; image.

    Zero failures/errors. Existing pending specs are unchanged (REST1, Staff12). Formatting/Ameba and final native builds/contracts pass. All four branches are clean, pushed and contain current master; downstream models pins agree. Draft PR descriptions/reviews and parent plan463 reflect the current contract. Staff remains domain-based, zone execution authorises only the zone, and drivers remain unchanged with the deferred ledger recorded above.

    Reconciliation safely blocks oversized snapshots, ambiguous multi-domain moves, unowned domain claims, staff-scope conversions and colliding grants; supported estate claims, source-owned single-domain moves and merges require reviewed previews. Operator review/management bootstrap and test-cluster rollout remain prerequisites before enabling enforcement. No merge, deployment or enforcement activation is performed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions