Skip to content

feat(place/vip_visitor_automation): expose workflow stages and simplify configuration - #652

Open
KesterJJ wants to merge 1 commit into
masterfrom
fix/place/vip-visitor-driver-packaging
Open

KesterJJ wants to merge 1 commit into
masterfrom
fix/place/vip-visitor-driver-packaging

Conversation

@KesterJJ

@KesterJJ KesterJJ commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The VIP workflow exposed only an all-in-one processing method, making individual stages difficult to test in Backoffice. It also fixed the Planner destination at module level and duplicated email presentation and notification controls in module settings.

This update adds administrator-only booking lookup, read-only preview and workflow status, independent invitation/confirmation/Planner/arrival/departure operations, and submit_confirmation with the actual AECB enrolment form fields. Submission merges the fields into the booking with the fixed vip_confirmed marker, then runs the confirmation workflow.

  • Resolve the Planner group from booking extension data with a module fallback; retain its destination once a plan exists.
  • Derive building_name and level_name from zone display names. Leave maps, parking and valet wording and recipient overrides to email templates; template presence controls arrival/departure sending.
  • Preserve progress and duplicate suppression across manual and event-driven calls. Honour cleared submitted beverage notes instead of restoring old organiser notes.
  • Fold the non-deployable Planner helper from feat(place/vip_visitor_automation): add VIP visitor workflow #650 into the automation driver and remove its misleading standalone source file. Document configuration, executable methods, form submission examples and task assignments.

Validation: the driver and expanded spec compiled and passed the PlaceOS harness (1 tested, 0 failures, 0 timeouts), with the old helper absent. Crystal formatting and git diff checks pass. Services were mocked; no live email or Planner resources were created.

External-form integration remains separate: the current frontend sends no acceptance marker, and the restricted guest token needs a scoped booking confirmation endpoint. The new Backoffice method tests the downstream workflow without claiming that external endpoint already exists. Existing deployed driver records are unchanged.

@KesterJJ
KesterJJ requested review from stakach and w-le November 17, 2026 10:50
@KesterJJ KesterJJ changed the title fix(place/vip_visitor_automation): inline Planner helper feat(place/vip_visitor_automation): expose workflow stages and simplify configuration Nov 18, 2026
@KesterJJ
KesterJJ force-pushed the fix/place/vip-visitor-driver-packaging branch from 1db1433 to 8240249 Compare November 18, 2026 08:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant